(fix): @fluentui/web-components storybook now starts up properly for Windows #19236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TristanWatanabe
requested review from
chrisdholt,
EisenbergEffect and
nicholasrice
as code owners
📊 Bundle size report🤖 This report was generated against 5948c4eb883dd97f14c4587c55b174ef81d8dbe7 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 5948c4eb883dd97f14c4587c55b174ef81d8dbe7 (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5f172bd:
|
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 865 | 878 | 5000 | |
| BaseButton | mount | 966 | 977 | 5000 | |
| Breadcrumb | mount | 2655 | 2673 | 1000 | |
| ButtonNext | mount | 452 | 435 | 5000 | |
| Checkbox | mount | 1697 | 1692 | 5000 | |
| CheckboxBase | mount | 1477 | 1400 | 5000 | |
| ChoiceGroup | mount | 5259 | 5195 | 5000 | |
| ComboBox | mount | 1054 | 1014 | 1000 | |
| CommandBar | mount | 10526 | 10257 | 1000 | |
| ContextualMenu | mount | 6493 | 6266 | 1000 | |
| DefaultButton | mount | 1198 | 1254 | 5000 | |
| DetailsRow | mount | 3881 | 3941 | 5000 | |
| DetailsRowFast | mount | 3956 | 3868 | 5000 | |
| DetailsRowNoStyles | mount | 3712 | 3726 | 5000 | |
| Dialog | mount | 2255 | 2230 | 1000 | |
| DocumentCardTitle | mount | 153 | 162 | 1000 | |
| Dropdown | mount | 3453 | 3456 | 5000 | |
| FluentProviderNext | mount | 7435 | 7206 | 5000 | |
| FocusTrapZone | mount | 1803 | 1864 | 5000 | |
| FocusZone | mount | 1795 | 1831 | 5000 | |
| IconButton | mount | 1867 | 1897 | 5000 | |
| Label | mount | 343 | 341 | 5000 | |
| Layer | mount | 1917 | 1862 | 5000 | |
| Link | mount | 498 | 509 | 5000 | |
| MakeStyles | mount | 1873 | 1904 | 50000 | |
| MenuButton | mount | 1620 | 1601 | 5000 | |
| MessageBar | mount | 2040 | 2082 | 5000 | |
| Nav | mount | 3433 | 3428 | 1000 | |
| OverflowSet | mount | 1083 | 1047 | 5000 | |
| Panel | mount | 2132 | 2161 | 1000 | |
| Persona | mount | 851 | 862 | 1000 | |
| Pivot | mount | 1503 | 1525 | 1000 | |
| PrimaryButton | mount | 1375 | 1392 | 5000 | |
| Rating | mount | 8202 | 8279 | 5000 | |
| SearchBox | mount | 1405 | 1466 | 5000 | |
| Shimmer | mount | 2731 | 2768 | 5000 | |
| Slider | mount | 2061 | 2066 | 5000 | |
| SpinButton | mount | 5257 | 5177 | 5000 | |
| Spinner | mount | 413 | 427 | 5000 | |
| SplitButton | mount | 3442 | 3328 | 5000 | |
| Stack | mount | 532 | 524 | 5000 | |
| StackWithIntrinsicChildren | mount | 1694 | 1675 | 5000 | |
| StackWithTextChildren | mount | 4944 | 4973 | 5000 | |
| SwatchColorPicker | mount | 11043 | 10748 | 5000 | |
| Tabs | mount | 1468 | 1459 | 1000 | |
| TagPicker | mount | 2766 | 2734 | 5000 | |
| TeachingBubble | mount | 12306 | 12090 | 5000 | |
| Text | mount | 466 | 471 | 5000 | |
| TextField | mount | 1466 | 1504 | 5000 | |
| ThemeProvider | mount | 1242 | 1238 | 5000 | |
| ThemeProvider | virtual-rerender | 618 | 610 | 5000 | |
| Toggle | mount | 890 | 870 | 5000 | |
| buttonNative | mount | 128 | 124 | 5000 |
Perf Analysis (@fluentui/react-northstar)
Perf tests with no regressions
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| TreeWith60ListItems.default | 207 | 185 | 1.12:1 |
| AnimationMinimalPerf.default | 465 | 421 | 1.1:1 |
| PortalMinimalPerf.default | 191 | 173 | 1.1:1 |
| ButtonMinimalPerf.default | 206 | 189 | 1.09:1 |
| FlexMinimalPerf.default | 302 | 277 | 1.09:1 |
| AvatarMinimalPerf.default | 216 | 202 | 1.07:1 |
| IconMinimalPerf.default | 715 | 671 | 1.07:1 |
| CardMinimalPerf.default | 614 | 578 | 1.06:1 |
| DialogMinimalPerf.default | 845 | 794 | 1.06:1 |
| DividerMinimalPerf.default | 395 | 371 | 1.06:1 |
| GridMinimalPerf.default | 379 | 357 | 1.06:1 |
| TextMinimalPerf.default | 389 | 368 | 1.06:1 |
| AttachmentMinimalPerf.default | 178 | 170 | 1.05:1 |
| ImageMinimalPerf.default | 414 | 396 | 1.05:1 |
| TableMinimalPerf.default | 469 | 445 | 1.05:1 |
| AccordionMinimalPerf.default | 170 | 163 | 1.04:1 |
| ChatDuplicateMessagesPerf.default | 322 | 310 | 1.04:1 |
| DropdownMinimalPerf.default | 3358 | 3215 | 1.04:1 |
| HeaderSlotsPerf.default | 818 | 788 | 1.04:1 |
| ListMinimalPerf.default | 570 | 548 | 1.04:1 |
| SkeletonMinimalPerf.default | 394 | 380 | 1.04:1 |
| StatusMinimalPerf.default | 755 | 723 | 1.04:1 |
| HeaderMinimalPerf.default | 396 | 385 | 1.03:1 |
| ItemLayoutMinimalPerf.default | 1338 | 1302 | 1.03:1 |
| LabelMinimalPerf.default | 422 | 409 | 1.03:1 |
| ListCommonPerf.default | 709 | 691 | 1.03:1 |
| LayoutMinimalPerf.default | 423 | 415 | 1.02:1 |
| ListWith60ListItems.default | 722 | 710 | 1.02:1 |
| ProviderMergeThemesPerf.default | 1755 | 1729 | 1.02:1 |
| SplitButtonMinimalPerf.default | 4217 | 4140 | 1.02:1 |
| CustomToolbarPrototype.default | 4091 | 3997 | 1.02:1 |
| AttachmentSlotsPerf.default | 1174 | 1168 | 1.01:1 |
| DropdownManyItemsPerf.default | 756 | 746 | 1.01:1 |
| EmbedMinimalPerf.default | 4360 | 4302 | 1.01:1 |
| ListNestedPerf.default | 602 | 599 | 1.01:1 |
| MenuMinimalPerf.default | 942 | 935 | 1.01:1 |
| TableManyItemsPerf.default | 2105 | 2075 | 1.01:1 |
| TreeMinimalPerf.default | 862 | 856 | 1.01:1 |
| ChatMinimalPerf.default | 682 | 681 | 1:1 |
| CheckboxMinimalPerf.default | 2886 | 2884 | 1:1 |
| MenuButtonMinimalPerf.default | 1832 | 1836 | 1:1 |
| PopupMinimalPerf.default | 622 | 623 | 1:1 |
| ProviderMinimalPerf.default | 1115 | 1112 | 1:1 |
| RadioGroupMinimalPerf.default | 495 | 495 | 1:1 |
| SegmentMinimalPerf.default | 387 | 387 | 1:1 |
| TextAreaMinimalPerf.default | 563 | 562 | 1:1 |
| AlertMinimalPerf.default | 297 | 300 | 0.99:1 |
| ButtonSlotsPerf.default | 580 | 583 | 0.99:1 |
| ChatWithPopoverPerf.default | 390 | 395 | 0.99:1 |
| InputMinimalPerf.default | 1321 | 1331 | 0.99:1 |
| LoaderMinimalPerf.default | 751 | 758 | 0.99:1 |
| SliderMinimalPerf.default | 1666 | 1680 | 0.99:1 |
| VideoMinimalPerf.default | 682 | 690 | 0.99:1 |
| BoxMinimalPerf.default | 368 | 377 | 0.98:1 |
| ButtonOverridesMissPerf.default | 1786 | 1830 | 0.98:1 |
| CarouselMinimalPerf.default | 498 | 506 | 0.98:1 |
| DatepickerMinimalPerf.default | 5647 | 5778 | 0.98:1 |
| ReactionMinimalPerf.default | 403 | 410 | 0.98:1 |
| ToolbarMinimalPerf.default | 995 | 1014 | 0.98:1 |
| TooltipMinimalPerf.default | 1070 | 1092 | 0.98:1 |
| RefMinimalPerf.default | 235 | 245 | 0.96:1 |
| FormMinimalPerf.default | 431 | 453 | 0.95:1 |
| RosterPerf.default | 1279 | 1357 | 0.94:1 |
ecraig12345
approved these changes
Aug 3, 2021
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
[ ] Addresses an existing issue: Fixes #0000$ yarn changeDescription of changes
web-componentspackage in Windows which yielded the error below, this PR fixes that issue: